-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Index key generation fix #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sion bumped to 0.23.0
ritwik-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandrasekharan-zipstack I have looked at the code from a very high level since the relation of same with existing code is not something that I know very well.
One major pattern I observed is that we have removed some of the instance variables. I would like you to double check and make sure those are not used in other repos and if they are we have made required changes
Co-authored-by: Ritwik G <100672805+ritwik-g@users.noreply.github.com> Signed-off-by: Chandrasekharan M <117059509+chandrasekharan-zipstack@users.noreply.github.com>
Signed-off-by: Chandrasekharan M <117059509+chandrasekharan-zipstack@users.noreply.github.com>
Signed-off-by: Chandrasekharan M <117059509+chandrasekharan-zipstack@users.noreply.github.com>
…or key generation
hari-kuriakose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandrasekharan-zipstack Doc ID generation looks good.
Please double check the impact on other areas.
What
Why
How
Can this PR break any existing features. If yes please list of possible items. If no please explain why. (PS: Admins do not merge the PR without this section filled)
Yes, since there's an update in the index key generated - all old index keys would be invalid. In order to perform a clean up - a migration has been added in Zipstack/unstract#289
Related PRs
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.