Support run_id / token usage for prompt runs #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaya3-zipstack
changed the title
gaya3-zipstack
requested review from
a team,
johnyrahul and
kirtimanmishrazipstack
and removed request for
a team
johnyrahul
reviewed
May 22, 2024
johnyrahul
reviewed
May 22, 2024
Contributor
johnyrahul
left a comment
johnyrahul
left a comment
There was a problem hiding this comment.
Left few comments . Please circle back on them so that I will havebetter clarity
hari-kuriakose
approved these changes
May 22, 2024
Contributor
hari-kuriakose
left a comment
hari-kuriakose
left a comment
There was a problem hiding this comment.
@gaya3-zipstack LGTM overall.
Ideally we should not expose LlamaIndex constructs at all anywhere. We could iteratively achieve this.
Signed-off-by: Hari John Kuriakose <hari@zipstack.com>
Contributor
|
@gaya3-zipstack LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
Dependencies Versions
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.