[FIX] Fixing timeout for prompt execution #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harini-venkataraman
requested review from
a team,
chandrasekharan-zipstack and
gaya3-zipstack
chandrasekharan-zipstack
approved these changes
Jun 9, 2024
Contributor
chandrasekharan-zipstack
left a comment
chandrasekharan-zipstack
left a comment
There was a problem hiding this comment.
@harini-venkataraman can you also remove the exception handling block added for Timeout? This won't be used if no timeout is passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes the max timeout hardcoded. And, unifies the timeout value set in the adapters/backend.
TO DO : To check the behaviour when the timeout handled by Llama index and take care of thhis in SDKs if needed.
...
Why
Timeout happens if the prompt executes more than 10min.
...
How
Removing the hardcoded timeout value.
...
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
...
Screenshots
...
Checklist
I have read and understood the Contribution Guidelines.