Skip to content

Conversation

@ritwik-g
Copy link
Contributor

What

  • Changed the logo link to fix pypy package
  • Fixed read me link at the end of doc

Why

...

How

...

Relevant Docs

Related Issues or PRs

Dependencies Versions / Env Variables

Notes on Testing

...

Screenshots

...

Checklist

I have read and understood the Contribution Guidelines.

Signed-off-by: Ritwik G <100672805+ritwik-g@users.noreply.github.com>
@CLAassistant
Copy link

CLAassistant commented Jul 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - you'll need to update the patch version in __init__.py to release this

@ritwik-g
Copy link
Contributor Author

LGTM - you'll need to update the patch version in __init__.py to release this

Should this be released just for a readme change? I think this can be rolled out in next release may be? @hari-kuriakose @chandrasekharan-zipstack

@hari-kuriakose
Copy link
Contributor

LGTM - you'll need to update the patch version in __init__.py to release this

Should this be released just for a readme change? I think this can be rolled out in next release may be? @hari-kuriakose @chandrasekharan-zipstack

@ritwik-g @chandrasekharan-zipstack Should be ok if README changes are directly picked up by PyPI. Let's see.

Copy link
Contributor

@hari-kuriakose hari-kuriakose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ritwik-g LGTM

@hari-kuriakose hari-kuriakose merged commit 04aa44d into main Jul 11, 2024
@hari-kuriakose hari-kuriakose deleted the fix-logo branch July 11, 2024 18:54
@hari-kuriakose
Copy link
Contributor

@ritwik-g @chandrasekharan-zipstack Seems like PyPI updates their CDN only when you publish. Hence if it's any critical README update, let's release it immediately. Otherwise should be ok to wait until next feature release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants