Skip to content

Conversation

@chandrasekharan-zipstack
Copy link
Contributor

@chandrasekharan-zipstack chandrasekharan-zipstack commented Aug 8, 2024

What

  • Error handling improvement for response from platform service
  • Minor log update for context during tool run
  • Bumped to 0.42.1

Why

  • Existing implementation does not display the error correctly

How

  • Since the SDK is used by tools and other services alike, raising a pythonic error rather than streaming logs alone

Related Issues or PRs

Notes on Testing

  • Tested along with OSS PR

Screenshots

...

Checklist

I have read and understood the Contribution Guidelines.

Copy link
Contributor

@Deepak-Kesavan Deepak-Kesavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Left a minor comment alone.

…vice

Signed-off-by: Chandrasekharan M <117059509+chandrasekharan-zipstack@users.noreply.github.com>
Copy link
Contributor

@kirtimanmishrazipstack kirtimanmishrazipstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deepak-Kesavan Deepak-Kesavan merged commit f8a425a into main Aug 9, 2024
@Deepak-Kesavan Deepak-Kesavan deleted the fix/adapter-error-handling-from-platform-service branch August 9, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants