Optimisation in passing callback manager #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaya3-zipstack
requested review from
chandrasekharan-zipstack,
hari-kuriakose and
kirtimanmishrazipstack
chandrasekharan-zipstack
approved these changes
Aug 29, 2024
hari-kuriakose
approved these changes
Aug 29, 2024
Contributor
hari-kuriakose
left a comment
hari-kuriakose
left a comment
There was a problem hiding this comment.
@gaya3-zipstack LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A small optimisation in passing callback manager in the context of the PR - #92
Why
This will avoid passing in callback manager from outside SDK
How
Use the callback manager attribute that is part of llama-index embedding instance
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
Tested Indexing and prompt answer
Screenshots
Checklist
I have read and understood the Contribution Guidelines.