fix(deps): cap protobuf below 7#1019
Merged
sokoliva merged 1 commit intoa2aproject:mainfrom Apr 27, 2026
Merged
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/events/event_queue_v2.py | 91.71% | 91.19% | 🔴 -0.52% |
| src/a2a/utils/telemetry.py | 91.41% | 90.63% | 🔴 -0.78% |
| Total | 93.03% | 93.00% | 🔴 -0.02% |
Generated by coverage-comment.yml
Member
|
Hi @liujuanjuan1984, Thank you for bringing this to our attention and for fixing the issue. I replicated the error you got and confirmed the fix you offered. |
sokoliva
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<7proto_utilsimplementation, which still relies onFieldDescriptor.labeluv.lockmetadata to matchWhy
a2a-sdk 1.0.2currently publishesprotobuf>=5.29.5, which allows resolvers to selectprotobuf 7.x.In downstream testing,
a2a-sdk==1.0.2withprotobuf==7.34.1crashes on theDefaultRequestHandler.on_get_task()path:@validate_request_paramsvalidate_proto_required_fields()_check_required_field_violation()AttributeError: 'google._upb._message.FieldDescriptor' object has no attribute 'label'This PR applies the minimal packaging fix that matches the current implementation choice from #1010 while broader code-level compatibility is discussed in #1011.
Relates to #1011
Validation
uv run ruff check --fixuv run ruff formatuv run mypy srcuv run pyright srcuv run pytestpytestresult locally:1671 passed, 90 skipped, 3 xfailed, 4 errorstests/integration/cross_version/client_server/test_client_server.pyserver_0_3.pysubprocess path usinguv run --with a2a-sdk[grpc]==0.3.24 --no-project ...