fix: fix docstrings related to CallContextBuilder args in constructors and make ServerCallContext mandatory in compat folder#907
Merged
sokoliva merged 9 commits intoa2aproject:1.0-devfrom Mar 27, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation and initialization logic for context_builder in JSON-RPC and REST routes to explicitly use DefaultCallContextBuilder when no builder is provided. Feedback was provided regarding redundant logic, as the underlying constructors already handle the default assignment for context_builder, making the explicit coalescing in the route creation functions unnecessary.
… fix-call-context
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/compat/v0_3/rest_adapter.py | 50.70% | 51.43% | 🟢 +0.72% |
| src/a2a/server/routes/rest_routes.py | 77.11% | 78.05% | 🟢 +0.94% |
| Total | 91.55% | 91.57% | 🟢 +0.02% |
Generated by coverage-comment.yml
sokoliva
changed the title
CallContextBuilder args in constructorsCallContextBuilder args in constructors and make ServerCallContext mandatory in compat folder
ishymko
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
CallContextBuilderargs in constructors from innaccurate "If None, no ServerCallContext is passed." to accurate "If None the DefaultCallContextBuilder is used."ServerCallContextmandatory in src/a2a/compat/v0_3/rest_adapter.py