Skip to content

fix: return updated agent_card in JsonRpcTransport.get_card() #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix: return updated agent_card in JsonRpcTransport.get_card() #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fb5b91
Fix: Return updated agent_card in JsonRpcTransport.get_card()
ShishirRmc Nov 19, 2025
c228b7a
Merge branch 'main' into fix/jsonrpc-get-card-return-value
ShishirRmc Nov 19, 2025
bf5acf1
updated verify get_card returns updated extended card
ShishirRmc Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/a2a/client/transports/jsonrpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ async def get_card(
raise A2AClientJSONRPCError(response.root)
self.agent_card = response.root.result
self._needs_extended_card = False
return card
return self.agent_card

async def close(self) -> None:
"""Closes the httpx client."""
Expand Down
2 changes: 1 addition & 1 deletion tests/client/test_jsonrpc_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,7 @@ async def test_get_card_with_extended_card_support(
mock_send_request.return_value = rpc_response
card = await client.get_card()

assert card == agent_card
assert card == AGENT_CARD_EXTENDED
mock_send_request.assert_called_once()
sent_payload = mock_send_request.call_args.args[0]
assert sent_payload['method'] == 'agent/getAuthenticatedExtendedCard'
Expand Down