Add Ledger as a Web3 provider

[slundy-ledger]

How it looks like once integrated into a Ledger hosted iframe

Enregistrement.de.l.ecran.2022-09-19.a.16.46.16.mov

[github-actions]

❌ CI run has failed!
Please see logs at https://github.com/aave/interface/actions/runs/3083771915'

[github-actions]

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
global	507.34 KB (🟡 +802 B)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

[slundy-ledger]

❌ CI run has failed! Please see logs at https://github.com/aave/interface/actions/runs/3083771915'

Hello @MareskoY
Could you give any pointer on what is wrong with the cypress test ?
I don't have any Tenderly account so I can't run them locally.

[MareskoY]

❌ CI run has failed! Please see logs at https://github.com/aave/interface/actions/runs/3083771915'

Hello @MareskoY Could you give any pointer on what is wrong with the cypress test ? I don't have any Tenderly account so I can't run them locally.

Hello @slundy-ledger, you need to merge your pr with the current main, i see that base brunch was too old, it should help i think

[github-actions]

❌ CI run has failed!
Please see logs at https://github.com/aave/interface/actions/runs/3098064911'

[slundy-ledger]

Hello again @MareskoY
feat/ledger-dappbrowser is now rebased on latest main commit 2f6ed447,
Previous base was commit 4a5cbcf which is main from this Monday.

[defispartan]

Hey @slundy-ledger, thanks for the contribution!

Is this package open source? All looks good from my side but I'd like to check the code before running our ci :)

[slundy-ledger]

Hello @defispartan
It is indeed an open source package, made by Lido @lidofinance/ledgerhq-frame-connector
It is the Ledger connector for web3-react based on @ledgerhq/iframe-provider. They are using it in the Lido app. Maybe they will integrate it directly in web3-react as connector.

[slundy-ledger]

Here is the link if you want to check the code -> https://github.com/lidofinance/ledgerhq-frame-connector

[github-actions]

❌ CI run has failed!
Please see logs at https://github.com/aave/interface/actions/runs/3103775468'

[MareskoY]

@slundy-ledger

test failing because of the wrong network, how I see it's happening because of local storage refreshing to clean one after opening any modal

before opening the modal

after opening the modal

For this reason, we get

looks like that ur changes somehow clean up the local storage of the app, what is wrong behavior

[slundy-ledger]

Hey @MareskoY

I tested locally: when opening the "connect wallet" modal, it does not clear my local storage.
https://user-images.githubusercontent.com/96065469/191797744-27d676fa-6cb9-482e-b097-1d0207d55208.mov

This makes me think there is an issue only while testing. Is there anything in cypress setup I should know about ? Something that should be updated ?

[defispartan]

I don't see anything in the package that would affect localStorage, so maybe this is an issue with the "Build PR from fork" job. I just manually ran this job on PR #973, could you check if the same issue is there @MareskoY ?

[MareskoY]

Hey @MareskoY

I tested locally: when opening the "connect wallet" modal, it does not clear my local storage. https://user-images.githubusercontent.com/96065469/191797744-27d676fa-6cb9-482e-b097-1d0207d55208.mov

This makes me think there is an issue only while testing. Is there anything in cypress setup I should know about ? Something that should be updated?

I don't see anything in the package that would affect localStorage, so maybe this is an issue with the "Build PR from fork" job. I just manually ran this job on PR #973, could you check if the same issue is there @MareskoY ?

@slundy-ledger @defispartan ,
I checked it locally and it has the same behavior as in CI

to run locally u just need to add .env.local with

TENDERLY_KEY=
TENDERLY_ACCOUNT=
TENDERLY_PROJECT=
CYPRESS_PERSIST_FORK_AFTER_RUN=true
URL=http://localhost:3000

I don't what is the reason for this behavior but there are no similar problems in any another PRs, so something wrong here but I couldn't say what exactly wrong

[MareskoY]

I don't see anything in the package that would affect localStorage, so maybe this is an issue with the "Build PR from fork" job. I just manually ran this job on PR #973, could you check if the same issue is there @MareskoY ?

it's different cases

[slundy-ledger]

@MareskoY
I was already running it locally using a correct .env.local. As you can see my local storage is not wiped when interacting with the "Provide ETH" modal. I don't know why it is wiped during cypress tests.

Enregistrement.de.l.ecran.2022-09-23.a.15.03.16.mov

@defispartan

I don't see anything in the package that would affect localStorage, so maybe this is an issue with the "Build PR from fork" job.

There is indeed no interaction with local storage. I also think there could an issue with "Build PR from fork".

[slundy-ledger]

Hello @MareskoY @defispartan, could you provide me the needed value for TENDERLY ?

TENDERLY_KEY=
TENDERLY_ACCOUNT=
TENDERLY_PROJECT=

So that i can run the tests locally

[MareskoY]

Hello @MareskoY @defispartan, could you provide me the needed value for TENDERLY ?

TENDERLY_KEY=
TENDERLY_ACCOUNT=
TENDERLY_PROJECT=

So that i can run the tests locally

TENDERLY_KEY=3IKa-OLADx82ovI46YTsgmNcYyjavRvF
TENDERLY_ACCOUNT=Aave
TENDERLY_PROJECT=QA

it's a temporary key, for 2 days

[slundy-ledger]

Hello @MareskoY @defispartan, could you provide me the needed value for TENDERLY ?

TENDERLY_KEY=
TENDERLY_ACCOUNT=
TENDERLY_PROJECT=

So that i can run the tests locally

TENDERLY_KEY=3IKa-OLADx82ovI46YTsgmNcYyjavRvF
TENDERLY_ACCOUNT=Aave
TENDERLY_PROJECT=QA

it's a temporary key, for 2 days

Thanks, 2 days should be enough

[slundy-ledger]

Hello again @defispartan @MareskoY

The CI failing test are working fine locally (example with the test from #1157 (comment) ) ->
https://user-images.githubusercontent.com/96065469/192586376-5dac0b0d-2278-4bc3-8fc2-8cc968e7cded.mov

I just had to add those lines

  env: {
    URL: "http://localhost:3000",
    TENDERLY_KEY:"3IKa-OLADx82ovI46YTsgmNcYyjavRvF",
    TENDERLY_ACCOUNT:"Aave",
    TENDERLY_PROJECT:"QA",
    NEXT_PUBLIC_ENV:"prod",
    NEXT_PUBLIC_ENABLE_GOVERNANCE:true,
    NEXT_PUBLIC_ENABLE_STAKING:true,
  },

into cypress.config.ts file because Cypress.env calls were returning nothing otherwise

Could you rerun the Github action ?

[github-actions]

✅ CI run has succeded!
You can find tests and deployment logs at https://github.com/aave/interface/actions/runs/3142941537'

[github-actions]

• Ipfs hash: bafybeifdsnh3c3eyqkaay347dt3c3p6ick432e7fbdgbh7jacfaplxr32u
• Ipfs preview link: https://bafybeifdsnh3c3eyqkaay347dt3c3p6ick432e7fbdgbh7jacfaplxr32u.ipfs.cf-ipfs.com/

[MareskoY]

@slundy-ledger Ci passed

[slundy-ledger]

@slundy-ledger Ci passed

@MareskoY what else is requested for this pull request to be merged ?

[drewcook]

Will be good to see it working in the Ledger UI

[MareskoY]

@slundy-ledger Ci passed

@MareskoY what else is requested for this pull request to be merged ?

from our side, all passed, just need to wait for the last review to merge

but we didn't check how it will work in the ledger app from our side, so I hope that it was tested from your side