feat: support dynamic balance text for asset input #1349
Conversation
drewcook
added
Ready for QA Review
| isMaxSelected={isMaxSelected} | ||
| disabled={withdrawTxState.loading} | ||
| maxValue={maxAmountToWithdraw.toString(10)} | ||
| balanceText={<Trans>Supply balance</Trans>} |
There was a problem hiding this comment.
Should this be Available?
There was a problem hiding this comment.
In case the amount available to withdraw < supply balance
There was a problem hiding this comment.
Yes, in all cases? Or just the edge-case when the liquidity isn't enough to cover?
There was a problem hiding this comment.
Right, I think optimally it makes sense to just state that for that one case, and Supply balance for all others
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖
|
| Page | Size (compressed) |
|---|---|
global |
471.39 KB (🟡 +89 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
One Page Changed Size
The following page changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/staking |
20.49 KB (🟡 +19 B) |
491.88 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
MareskoY
added
QC Passed
and removed
Ready for QA Review
defispartan
left a comment
defispartan
left a comment
There was a problem hiding this comment.
update WithdrawModal text
|
|
* feat: support dynamic balance text for asset input * chore: withdraw modal text * chore: use lt() method
General Changes
AssetInputacross the UIDeveloper Notes
Add any notes here that may be helpful for reviewers.
Author Checklist
Please ensure you, the author, have gone through this checklist to ensure there is an efficient workflow for the reviewers.
mainIf the PR is ready for review:
Openstate and not inDraftmodeReady for Dev Reviewlabel has been addedReviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files