Skip to content

Conversation

@mdqst
Copy link
Contributor

@mdqst mdqst commented Nov 3, 2024

Снимок экрана 2024-11-03 в 22 09 24

Misspelled as "Prococol" instead of "Protocol."
Corrected.

Misspelled as "Prococol" instead of "Protocol."
Correction: "Aave Protocol"
@height
Copy link

height bot commented Nov 3, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@grothem grothem changed the title Typo Update CONTRIBUTING.md Typo Update CONTRIBUTING.md [skip cypress] Nov 13, 2024
@github-actions
Copy link

github-actions bot commented Nov 13, 2024

❌ CI run has failed!
Please see logs at https://github.com/aave/interface/actions/runs/11821438147'

@github-actions
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 542.8 KB (🟡 +1.39 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Eleven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/ 47.89 KB (🟡 +560 B) 590.69 KB
/bridge 36.21 KB (🟡 +181 B) 579.01 KB
/faucet 15.1 KB (🟡 +1 B) 557.91 KB
/governance 84.17 KB (-2 B) 626.97 KB
/governance/ipfs-preview 97.58 KB (🟡 +1 B) 640.38 KB
/governance/v3/proposal 124.15 KB (-1 B) 666.95 KB
/history 23.79 KB (🟡 +19 B) 566.59 KB
/markets 27.55 KB (🟡 +695 B) 570.35 KB
/reserve-overview 19.68 KB (-1 B) 562.48 KB
/staking 22.82 KB (🟢 -17 B) 565.62 KB
/v3-migration 29.96 KB (🟢 -213 B) 572.76 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@grothem grothem merged commit cde7a13 into aave:main Nov 13, 2024
11 checks passed
@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants