feat: added support for multiple rewardedassets per campaign #2756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AGMASO
requested review from
JoaquinBattilana,
foodaka,
grothem and
mgrabina
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
mgrabina
reviewed
Nov 10, 2025
| > | ||
| <Box sx={{ display: 'inline-flex', alignItems: 'center' }}> | ||
| <FormattedNumber | ||
| value={merklIncentives.breakdown.isBorrow ? -reward.apr : reward.apr} |
Contributor
There was a problem hiding this comment.
should we convert apr to apy
Collaborator
Author
There was a problem hiding this comment.
Bad variable names from me, I’ve changed them now for clarity.
Comment on lines
+266
to
+267
| ? -merklIncentives.breakdown.merklIncentivesAPR | ||
| : merklIncentives.breakdown.merklIncentivesAPR |
Collaborator
Author
There was a problem hiding this comment.
merklIncentives.breakdown.merklIncentivesAPR represents already APY see here:
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
mgrabina
approved these changes
Nov 11, 2025
foodaka
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Changes
Refactored the incentives Merkl code to support multiple rewarded assets within a single campaign, as well as multiple campaigns targeting the same aToken/vToken with different rewarded tokens.
Based the filtering on the onChainCampaignId, which is unique for each rewarded token, simplifying the code and making it agnostic to these different scenarios.
Developer Notes
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files