Skip to content

fix: swaps misc #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 19, 2025
Merged

fix: swaps misc #2768

merged 5 commits into from
Nov 19, 2025

Conversation

@mgrabina
Copy link
Contributor

@mgrabina mgrabina commented Nov 18, 2025 •
edited
Loading

  1. we just avoid users bypass the warning if the final HF is liquidatable (not low)
  2. re check balance guard correctly on new amount lower
  3. dont show flashloan fee cost on non flashloan flow collateral swaps
  4. nit for quote refresh on inputs changed
  5. distinguish error vs gas estimation in analytics for paraswap flows

@mgrabina mgrabina marked this pull request as ready for review November 18, 2025 23:31
@vercel
Copy link

vercel bot commented Nov 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
interface Ready Ready Preview Comment Nov 19, 2025 1:47am

@mgrabina mgrabina force-pushed the fix/HF-warning-swaps-condition branch from 0659366 to 04ebd55 Compare November 18, 2025 23:31
@mgrabina mgrabina changed the title fix: correct liquidatable HF condition for warning fix: correct condition for HF warning bypass checkbox Nov 18, 2025
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mgrabina mgrabina changed the title fix: correct condition for HF warning bypass checkbox fix: swaps warnings Nov 19, 2025
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mgrabina mgrabina changed the title fix: swaps warnings fix: swaps misc Nov 19, 2025
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mgrabina mgrabina merged commit b8ad032 into main Nov 19, 2025
15 of 21 checks passed
@mgrabina mgrabina deleted the fix/HF-warning-swaps-condition branch November 19, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoaquinBattilana JoaquinBattilana JoaquinBattilana approved these changes

@grothem grothem grothem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mgrabina @JoaquinBattilana @grothem