Skip to content

Conversation

@maki49
Copy link
Contributor

@maki49 maki49 commented Apr 5, 2023

@dyzheng dyzheng requested a review from PeizeLin April 19, 2023 06:50
@maki49
Copy link
Contributor Author

maki49 commented Apr 19, 2023

@PeizeLin did some tests: compiling OpenBLAS with ifort and gfortran respectively yields different interface of zdotc_ and zdotu_.
bb93231673313764894fd17672fcda3

So the conclusion is that using ___MKL to seperate two kinds of interfaces is unreasonable. That's why I rewrite this PR.

We reached an agreement to implement customized "dotc" and "dotu" based on sdot_ and ddot_. I've put the formulas in the comments and added unittests with different 'incX' and 'incY'.

@PeizeLin PeizeLin closed this Apr 19, 2023
@PeizeLin PeizeLin reopened this Apr 19, 2023
@PeizeLin PeizeLin merged commit e7e6a4d into abacusmodeling:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New EXX implementation not working with gcc+openmpi+openblas

3 participants