Skip to content

Commit f7fadf3

Browse files
jpirkodavem330
authored andcommitted
switchdev: make struct switchdev_attr parameter const for attr_set calls
Signed-off-by: Jiri Pirko <jiri@mellanox.com> Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 793f401 commit f7fadf3

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

drivers/net/ethernet/rocker/rocker.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4374,7 +4374,7 @@ static int rocker_port_bridge_ageing_time(struct rocker_port *rocker_port,
43744374
}
43754375

43764376
static int rocker_port_attr_set(struct net_device *dev,
4377-
struct switchdev_attr *attr,
4377+
const struct switchdev_attr *attr,
43784378
struct switchdev_trans *trans)
43794379
{
43804380
struct rocker_port *rocker_port = netdev_priv(dev);

include/net/switchdev.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ struct switchdev_ops {
132132
int (*switchdev_port_attr_get)(struct net_device *dev,
133133
struct switchdev_attr *attr);
134134
int (*switchdev_port_attr_set)(struct net_device *dev,
135-
struct switchdev_attr *attr,
135+
const struct switchdev_attr *attr,
136136
struct switchdev_trans *trans);
137137
int (*switchdev_port_obj_add)(struct net_device *dev,
138138
const struct switchdev_obj *obj,
@@ -171,7 +171,7 @@ void switchdev_deferred_process(void);
171171
int switchdev_port_attr_get(struct net_device *dev,
172172
struct switchdev_attr *attr);
173173
int switchdev_port_attr_set(struct net_device *dev,
174-
struct switchdev_attr *attr);
174+
const struct switchdev_attr *attr);
175175
int switchdev_port_obj_add(struct net_device *dev,
176176
const struct switchdev_obj *obj);
177177
int switchdev_port_obj_del(struct net_device *dev,
@@ -220,7 +220,7 @@ static inline int switchdev_port_attr_get(struct net_device *dev,
220220
}
221221

222222
static inline int switchdev_port_attr_set(struct net_device *dev,
223-
struct switchdev_attr *attr)
223+
const struct switchdev_attr *attr)
224224
{
225225
return -EOPNOTSUPP;
226226
}

net/dsa/slave.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ static int dsa_slave_stp_update(struct net_device *dev, u8 state)
453453
}
454454

455455
static int dsa_slave_port_attr_set(struct net_device *dev,
456-
struct switchdev_attr *attr,
456+
const struct switchdev_attr *attr,
457457
struct switchdev_trans *trans)
458458
{
459459
struct dsa_slave_priv *p = netdev_priv(dev);

net/switchdev/switchdev.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ int switchdev_port_attr_get(struct net_device *dev, struct switchdev_attr *attr)
215215
EXPORT_SYMBOL_GPL(switchdev_port_attr_get);
216216

217217
static int __switchdev_port_attr_set(struct net_device *dev,
218-
struct switchdev_attr *attr,
218+
const struct switchdev_attr *attr,
219219
struct switchdev_trans *trans)
220220
{
221221
const struct switchdev_ops *ops = dev->switchdev_ops;
@@ -274,7 +274,7 @@ static void switchdev_port_attr_set_work(struct work_struct *work)
274274
}
275275

276276
static int switchdev_port_attr_set_defer(struct net_device *dev,
277-
struct switchdev_attr *attr)
277+
const struct switchdev_attr *attr)
278278
{
279279
struct switchdev_attr_set_work *asw;
280280

@@ -303,7 +303,8 @@ static int switchdev_port_attr_set_defer(struct net_device *dev,
303303
* system is not left in a partially updated state due to
304304
* failure from driver/device.
305305
*/
306-
int switchdev_port_attr_set(struct net_device *dev, struct switchdev_attr *attr)
306+
int switchdev_port_attr_set(struct net_device *dev,
307+
const struct switchdev_attr *attr)
307308
{
308309
struct switchdev_trans trans;
309310
int err;

0 commit comments

Comments
 (0)