switch to '\n' for EventSourceResponse separator#1188
Merged
abetlen merged 2 commits intoabetlen:mainfrom Feb 15, 2024
khimaros:patch-1
Merged
switch to '\n' for EventSourceResponse separator#1188abetlen merged 2 commits intoabetlen:mainfrom khimaros:patch-1
abetlen merged 2 commits intoabetlen:mainfrom
khimaros:patch-1
Conversation
this fixes compatibility with some OpenAI clients, including BetterChatGPT (ztjhz/BetterChatGPT#537).
Contributor
Author
|
note that BetterChatGPT client still has trouble with |
Owner
|
@khimaros makes sense, I'm assuming the |
Owner
|
Thank you, I'll go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes compatibility with some OpenAI clients, including BetterChatGPT (ztjhz/BetterChatGPT#537). i'm not sure if this will cause problems with other clients. i'm also working with the client to see if they are willing to handle these separators more gracefully.