Fix: Propagate flash attn to model loader#1424
Merged
abetlen merged 1 commit intoabetlen:mainfrom May 3, 2024
dthuerck:propagate-flash-attn
Merged
Fix: Propagate flash attn to model loader#1424abetlen merged 1 commit intoabetlen:mainfrom dthuerck:propagate-flash-attn
abetlen merged 1 commit intoabetlen:mainfrom
dthuerck:propagate-flash-attn
Conversation
Owner
|
@dthuerck thank you! |
|
I installed the latest version of llama_cpp_python (0.2.70) with this command: But after using it on oobabooga's software (llama_cpp_hf), I still have this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that even though setting
flash_attntotruein my model config file,llama.cppkept reportingllama_new_context_with_model: flash_attn = 0. This super-small PR fixes that - turns out the setting wasn't passed on to the model loader.