fix: Make LLamaState pickleable for disk cache #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed the issue by making the saved state a bytes object instead of the ctypes one which can't be pickled.
xaptronic
pushed a commit
to xaptronic/llama-cpp-python
that referenced
this pull request
Jun 13, 2023
* Major refactoring - introduce C-style API * Clean up * Add <cassert> * Add <iterator> * Add <algorithm> .... * Fix timing reporting and accumulation * Measure eval time only for single-token calls * Change llama_tokenize return meaning
xaptronic
pushed a commit
to xaptronic/llama-cpp-python
that referenced
this pull request
Jun 13, 2023
gjmulder
changed the title
Contributor
|
Bump |
abetlen
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the issue by making the saved state a bytes object instead of the ctypes one which can't be pickled.
Not sure if this is ideal though, maybe the copy on loading from cache can be avoided.
Stumbled upon another bug in the disk cache which caused it to crash on pushing keys using the disk cache library.
When using
cache.push(), an integer gets put into the cache as a key(see documentation) which then won't be comparable to the token sequence on subsequent cache fetches.I commented that line out for now but there should be a better way to handle this.