Skip to content

Conversation

@daniele-pini
Copy link
Contributor

Summary

This PR fixes retries for upcoming assertions on commands react and getReact. Closes #339.

@daniele-pini
Copy link
Contributor Author

@abhinaba-ghosh, was there a specific reason to add the then() at the end? I'm wondering because it doesn't seem to have a purpose, but maybe I'm wrong?

@abhinaba-ghosh
Copy link
Owner

Hi @daniele-pini thanks for raising this PR. This makes sense.

@abhinaba-ghosh abhinaba-ghosh merged commit eab0da7 into abhinaba-ghosh:master Jun 17, 2022
@daniele-pini daniele-pini deleted the fix_retry_upcoming_assertions branch June 17, 2022 08:29
@abhinaba-ghosh
Copy link
Owner

This should be available in version 2.3.19

@daniele-pini
Copy link
Contributor Author

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Functions react() and getReact() don't retry upcoming assertions

2 participants