[Fix] Using okResponse() without content hangs the connection
#1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
abhinavsingh
commented
Jan 26, 2022
abhinavsingh
commented
- It hangs because of no content-length or connection close header
- Fixes [Core] Queueing an empty response can hang the connection #1028
abhinavsingh
added
the
bot:chronographer:skip
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1062 +/- ##
===========================================
- Coverage 87.81% 87.72% -0.10%
===========================================
Files 165 165
Lines 6779 6777 -2
Branches 680 679 -1
===========================================
- Hits 5953 5945 -8
- Misses 714 721 +7
+ Partials 112 111 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
abhinavsingh
added a commit
that referenced
this pull request
Jan 26, 2022
* [Core] Invoke selector.close on shutdown (#1055) [Core] Invoke `selector.close` on shutdown * [CacheResponsesPlugin] Add ability to cache request packets (#1056) * Start of post encryption tests * Assertion on post encryption callback * Add `--cache-requests` flag * Clean up `on_client_data` API as we no longer have a chain within core http protocol handler * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix flake8 warnings * Fix `inconsistent-return-statements` Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [Task] A generic payload based work abstraction (#1057) * Refactor into an internal task submodule of work * As context managers * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add missing license Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * `jupyter` notebook based tutorial (#1059) * `jupyter` notebook based tutorial * Move within `tutorial` directory * Fix spell * Add `as_non_blocking` option during wrap * `as_non_blocking=False` by defaut * `--max-sendbuf-size` flag to speed up large file upload/download (#1060) * Add `--max-sendbuf-size` flag which now defaults to 64Kb * Use `server_recvbuf_size` flag with base tunnel implementation * isort * Add to readme * [Flags] `min_compression_length` consistency (#1061) * `min_compression_length` consistency, it was used as `min_compression_limit` at a few places * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * revert back web server route * Move `serve_static_file` as a staticmethod within web plugin base Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [Fix] Using `okResponse()` without content hangs the connection (#1062) * It hangs because of no content-length or connection close header * Fix tests * [Jupyter] Add a response notebook (#1064) * Add a response generation jupyter notebook * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Make codespell happy * precommit codespell exclude Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [Optimize] Avoid using `tobytes` for zero-copies (#1066) * Avoid using `tobytes` where possible * `send` accepts `Union[memoryview, bytes]` now * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [HttpParser] Memory view compliant, Zero copies (#1067) * Remove usage of `tobytes` * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix chunk parser * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Lint fixes Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [Jupyter] Request creation notebook (#1065) * Add plugin tests, responses notebook and enhancements to `build_http_packet` * Add js code snip for ws example * Fix tests * ignore all ipynb from codespell * ignore all ipynb from codespell * Fix tests and doc spell Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.