Skip to content

Conversation

@abhinavsingh
Copy link
Owner

@abhinavsingh abhinavsingh commented Jun 17, 2020

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #375 into develop will increase coverage by 0.01%.
The diff coverage is 91.17%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #375      +/-   ##
===========================================
+ Coverage    81.45%   81.47%   +0.01%     
===========================================
  Files           72       72              
  Lines         2810     2813       +3     
===========================================
+ Hits          2289     2292       +3     
  Misses         521      521              
Impacted Files Coverage Δ
proxy/common/flags.py 97.80% <88.46%> (-0.06%) ⬇️
proxy/common/constants.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16af678...bbbd3a9. Read the comment docs.

@abhinavsingh abhinavsingh changed the title Move static values to constants.py Enable docker containers for TLS Interception Jun 17, 2020
@abhinavsingh
Copy link
Owner Author

@whitespots Haven't pushed docker image yet, but you can build one locally and give it a try. Refer to documentation here https://github.com/abhinavsingh/proxy.py/tree/shared-argparse#tls-interception-with-docker , need to polish a few things before merge and release.

Lemme know if you encounter any issues. Thank you!!!

@abhinavsingh
Copy link
Owner Author

@Benouare @httpnotonly @ja8zyjits @roshanprince402 @tawmoto folks jFYI

@abhinavsingh abhinavsingh merged commit 62012ed into develop Jun 17, 2020
@abhinavsingh abhinavsingh deleted the shared-argparse branch June 17, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants