Skip to content

Conversation

@o1egl
Copy link

@o1egl o1egl commented Dec 2, 2020

No description provided.

@o1egl o1egl requested a review from abice as a code owner December 2, 2020 13:37
@abice
Copy link
Owner

abice commented Dec 2, 2020

Hi @o1egl

Can you give a little info as to why you might need an uppercase version that the lowercase version doesn't already support?

@abice
Copy link
Owner

abice commented Dec 3, 2020

Also, go ahead and merge master into your fork. That should make the build work on circle. Sorry about that!

@o1egl
Copy link
Author

o1egl commented Dec 3, 2020

My case is opposite to the case where you need lowercase param. Enums are defined in lowercase and now I also need to support uppercase aliases.

@abice
Copy link
Owner

abice commented Dec 11, 2020

Hi @o1egl

After looking back at the code base, it seems that my implementation of the lower flag was supposed to provide case insensitive lookups for users, not simply to provide a lower case alias of them. Would modifying the parse function to lookup both lowercase and original value suffice for your use case? Or do you need an uppercase variant included with nothing allowed in between?

@o1egl
Copy link
Author

o1egl commented Dec 12, 2020

I'm fine having case insensitive lookup option. But let's rename it from --lower to --case-insensitive or something similar.

@abice
Copy link
Owner

abice commented Dec 13, 2020

I don't want to break things that are already out there in the world, so renaming isn't something I'm fond of, but we can surely add an alias that makes more sense and does the same thing as --lower.

@abice
Copy link
Owner

abice commented Feb 16, 2021

Finally created a new flag: #45

@o1egl Let me know if that will solve your problem!

@o1egl
Copy link
Author

o1egl commented Feb 22, 2021

Yes, I think we can close this PR

@o1egl o1egl closed this Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants