Skip to content

swap to using constants instead of int values. #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2021
Merged

swap to using constants instead of int values. #71

merged 1 commit into from
Nov 5, 2021

Conversation

@abice
Copy link
Owner

@abice abice commented Nov 5, 2021

Fixes #70

Thanks for the idea, it definitely looks better and is easier to understand with these changes.

@coveralls
Copy link

coveralls commented Nov 5, 2021

Coverage Status

Coverage increased (+0.007%) to 92.901% when pulling 83bf7b4 on abice/useConsts into 6e988a2 on master.

@abice abice merged commit 5a95b1b into master Nov 5, 2021
@abice abice deleted the abice/useConsts branch November 5, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recommendation: Use const instead of plain numbers in internal map

3 participants

@abice @coveralls