Minor cleaning of structure.ipynb and some other notebooks #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmatteo
reviewed
Aug 1, 2018
| " to certain standards. The standards are defined in\n", | ||
| " doi:10.1016/j.commatsci.2010.05.010\n", | ||
| " to certain standards. The standards are defined by\n", | ||
| " [Setyawan2010](https://doi.org/10.1016/j.commatsci.2010.05.010)\n", |
There was a problem hiding this comment.
This section of the jupyter notebook is automatically produced by executing:
!abistruct.py --help
so one should change the source code of abistruct.py in the AbiPy repo
else these changes will be overwritten the next time I regenerate the notebook.
There was a problem hiding this comment.
OK, I overlooked this (obvious) point.
I have now made a slightly different modification to abistruct.py !
Best,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.