-
Notifications
You must be signed in to change notification settings - Fork 28
Release/2.1.0 #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/2.1.0 #626
Conversation
WalkthroughBumped package/library version to 2.1.0, added a v2.1.0 CHANGELOG entry documenting VCDiff delta-compressed message support, updated optional dependency for Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Client as Client (app)
participant SDK as Ably SDK
participant Service as Ably Service
Note over Client,SDK: VCDiff option enabled in client options
Client->>SDK: open connection / subscribe
Service->>SDK: send message (base content + delta, headers indicate VCDiff)
alt VCDiff enabled & delta present
SDK->>SDK: fetch/identify base content
SDK->>SDK: run vcdiff-decoder to apply delta
SDK->>Client: deliver reconstructed full payload
else VCDiff not enabled or unavailable
SDK->>Client: deliver message as-is (delta metadata preserved)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
pyproject.toml (1)
3-3: Poetry version updated correctly; confirm prerelease extra intent.
vcdiff-decoder = "^0.1.0a1"(optional) is a prerelease. If shipping a stable SDK depending on this feature, confirm the prerelease dependency is intentional for end users; otherwise consider pinning to a stable once available.If intentional, consider noting it in the CHANGELOG entry (e.g., “Install with ably[vcdiff]; this currently uses a prerelease decoder”).
CHANGELOG.md (2)
3-3: Add release date to header for consistency.Most historical entries include dates; adding one improves traceability.
Apply:
-## [v2.1.0](https://github.com/ably/ably-python/tree/v2.1.0) +## [v2.1.0](https://github.com/ably/ably-python/tree/v2.1.0) (2025-09-18)
9-11: Clarify how to enable VCDIFF support.Since the decoder is an optional extra, add a brief installation/use note to avoid confusion.
Apply:
-* Added support for VCDIFF delta-compressed messages. When deltas are provided by the service, -the SDK reconstructs full message payloads from the base content and the received delta, -reducing bandwidth usage without changing your application code. +* Added support for VCDIFF delta-compressed messages. When deltas are provided by the service, + the SDK reconstructs full message payloads from the base content and the received delta, + reducing bandwidth usage with no API changes required. + To enable, install the optional extra: `pip install "ably[vcdiff]"`. + (Note: the decoder dependency is currently a prerelease.)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)ably/__init__.py(1 hunks)pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: check (3.10)
- GitHub Check: check (3.7)
- GitHub Check: check (3.11)
- GitHub Check: check (3.8)
- GitHub Check: check (3.13)
- GitHub Check: check (3.12)
- GitHub Check: check (3.9)
🔇 Additional comments (1)
ably/__init__.py (1)
19-19: Version bump LGTM — no repo-wide changes required.lib_version and pyproject.toml version both 2.1.0. The only "2.0.13" matches are historical references in CHANGELOG.md (lines 5, 13, 15); no action needed.
42e600e to
fcc8459
Compare
VeskeR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approved.
Small nitpick about unnecessary new line
fcc8459 to
a36fab9
Compare
- make more strict vcdiff-decoder version - update release job
a36fab9 to
b41d8f8
Compare
Full Changelog
What's Changed
the SDK reconstructs full message payloads from the base content and the received delta,
reducing bandwidth usage without changing your application code.
Summary by CodeRabbit