-
Notifications
You must be signed in to change notification settings - Fork 46
Improve getting started project setup instructions #2605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| ``` | ||
|
|
||
| * Create a new project in your IDE and install the Ably Chat JavaScript SDK. This will also install the Ably Pub/Sub SDK as it is a dependency: | ||
| * Install "Node.js":https://nodejs.org/en version 18 or greater. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we recommend 22 LTS?
On that note, node 18 is now (as of last month) no longer maintained, so we should probably drop support: remove 18 and add 24 to tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah good spot!
I think i'll change the wording here to "any LTS version of Node.js", wdyt?
I agree we should revisit support in the sdk too 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 👍
m-hulbert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @owenpearson !
59aead6 to
976f67d
Compare
976f67d to
7065538
Compare
Fixes a couple of issues with the javascript project setup here:
tscrequirement, now this is explicitly installed with NPM and used from the installed package rather than expected to be installed globally.npm installbeforenpm init -y, both of these commands createpackage.jsonif it doesn't already exist but generally you're supposed to init the project first.