-
Notifications
You must be signed in to change notification settings - Fork 46
EDU-2114: Converts SSE page to MDX #2913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dfb305a to
02fa986
Compare
67c765c to
31ce47a
Compare
GregHolmes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few rendering issues here but other than that it's good
f61fb9e to
937ee64
Compare
GregHolmes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments. But I think these should also apply to your other PR.
bef123e to
d14fd4a
Compare
src/pages/docs/api/sse.mdx
Outdated
| ##### Code example | ||
|
|
||
| <If lang="javascript"> | ||
| <Code language="javascript"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just it shouldn't have the language=" part. I think AI keeps wanting to add it in. Has done for me in the past.
347d5f7 to
398aa83
Compare
This PR:
https://ably.com/docs/api/sseto MDXEDU-2114