Skip to content

Conversation

@franrob-projects
Copy link
Contributor

@franrob-projects franrob-projects commented Oct 22, 2025

This PR:

  • Converts https://ably.com/docs/api/sse to MDX

EDU-2114

@franrob-projects franrob-projects added the review-app Create a Heroku review app label Oct 22, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 22, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch EDU-2114-convert-sse-api-ref-to-mdx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ably-ci ably-ci temporarily deployed to ably-docs-edu-2114-conv-nb75qw October 22, 2025 14:07 Inactive
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-2114-conv-nb75qw October 23, 2025 14:14 Inactive
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-2114-conv-nb75qw October 23, 2025 14:55 Inactive
@franrob-projects franrob-projects force-pushed the EDU-2114-convert-sse-api-ref-to-mdx branch from dfb305a to 02fa986 Compare October 23, 2025 14:57
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-2114-conv-nb75qw October 23, 2025 14:57 Inactive
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-2114-conv-nb75qw October 27, 2025 10:06 Inactive
@franrob-projects franrob-projects force-pushed the EDU-2114-convert-sse-api-ref-to-mdx branch from 67c765c to 31ce47a Compare October 27, 2025 11:07
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-2114-conv-nb75qw October 27, 2025 11:07 Inactive
Copy link
Contributor

@GregHolmes GregHolmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few rendering issues here but other than that it's good

@franrob-projects franrob-projects force-pushed the EDU-2114-convert-sse-api-ref-to-mdx branch from f61fb9e to 937ee64 Compare November 3, 2025 11:18
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-2114-conv-wnxfgt November 3, 2025 11:20 Inactive
Copy link
Contributor

@GregHolmes GregHolmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments. But I think these should also apply to your other PR.

@franrob-projects franrob-projects had a problem deploying to ably-docs-edu-2114-conv-wnxfgt November 5, 2025 15:26 Failure
@franrob-projects franrob-projects force-pushed the EDU-2114-convert-sse-api-ref-to-mdx branch from bef123e to d14fd4a Compare November 5, 2025 16:28
@franrob-projects franrob-projects temporarily deployed to ably-docs-edu-2114-conv-wnxfgt November 5, 2025 16:28 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2114-conv-holx1z November 5, 2025 16:53 Inactive
##### Code example

<If lang="javascript">
<Code language="javascript">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just it shouldn't have the language=" part. I think AI keeps wanting to add it in. Has done for me in the past.

@GregHolmes GregHolmes force-pushed the EDU-2114-convert-sse-api-ref-to-mdx branch from 347d5f7 to 398aa83 Compare November 7, 2025 10:03
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2114-conv-holx1z November 7, 2025 10:03 Inactive
@GregHolmes GregHolmes temporarily deployed to ably-docs-edu-2114-conv-grnl5b November 7, 2025 10:13 Inactive
@GregHolmes GregHolmes merged commit a6de668 into main Nov 7, 2025
6 checks passed
@GregHolmes GregHolmes deleted the EDU-2114-convert-sse-api-ref-to-mdx branch November 7, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

4 participants