[WEB-4321] Local examples TLC #3005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
When users copy/paste the lines they'll probably end up with an error, unless by some chance an `/examples` directory exists at the root of their volume. By dropping the leading slash we stay relative to the repo and all will be good
GregHolmes
force-pushed
the
WEB-4321-local-examples-tlc
branch
from
dc8b0d1 to
f4ba229
Compare
GregHolmes
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Playing around with the examples locally and found some minor improvements and fixes.
The biggest change is probably just the copy where we tell users to
cd /examples/, which should becd examples/. Second to that is a missing dependency for franken-ui.Checklist