Support Click 8 #19
Merged
Support Click 8 #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: aboutcode-org/scancode-toolkit#2529 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
See: aboutcode-org/scancode-toolkit#2529 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
- In particular this help things work with Click 8.x - The hidden argument is now standard so remove it together with special code. See: aboutcode-org/scancode-toolkit#2529 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
See: aboutcode-org/scancode-toolkit#2529 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
This is now standard but only in Click version 8 We still nee to do it ourselves for older versions. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
5 tasks
Pratikrocks
pushed a commit
to Pratikrocks/commoncode
that referenced
this pull request
Jun 10, 2021
Update boilerplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ScanCode, these
are reported as issues and are linked to the upgrade of Click when using a pypi pip install (without pinned requirements)
This fixes these issues