fix whiteout opaque prefix #39
Conversation
Per - https://github.com/opencontainers/image-spec/blob/main/layer.md#whiteouts An opaque whiteout entry is a file with the name `.wh..wh..opq` but code is currently missing the second second dot
pombredanne
left a comment
pombredanne
left a comment
There was a problem hiding this comment.
Thank you ++ ... this is a great catch!
I guess a small dot is enough to make the tests fail... Do you mind to help update them too?
|
This made me think that we may not be handling ".wh..wh..plnk" correctly or at all... This is the opportunity to get this corrected too IMHO. |
I do not see |
Yes... that's the point! we are missing this entirely. |
|
gentle ping ... I would like to merge this soon enough ... but I cannot if we have tests failing. |
|
Never mind... I will handle this directly and make the correction in a new branch including the plnk support |
* Do not skip opaque whiteouts * Do not treat whiteouts as relative paths * Log error for legacy .plnk and .aufs AUFS whiteouts * "Per https://github.com/opencontainers/image-spec/blob/main/layer.md#whiteouts An opaque whiteout entry is a file with the name .wh..wh..opq but code is currently missing the second second dot" Reported-by: AJ Arena @sig-aarena Reference: #39 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Do not skip opaque whiteouts * Do not treat whiteouts as relative paths * Log error for legacy .plnk and .aufs AUFS whiteouts * "Per https://github.com/opencontainers/image-spec/blob/main/layer.md#whiteouts An opaque whiteout entry is a file with the name .wh..wh..opq but code is currently missing the second second dot" Reported-by: AJ Arena @sig-aarena Reference: #39 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
|
@sig-aarena FYI, this is fixed there 7ad595b |
2 participants
Per - https://github.com/opencontainers/image-spec/blob/main/layer.md#whiteouts
An opaque whiteout entry is a file with the name
.wh..wh..opqbut code is currently missing the second second dot