Fix option to skip symlinks in extract_tar #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
commented
Jun 23, 2022
| continue | ||
|
|
||
| if tarinfo.islnk() or tarinfo.issym(): | ||
| if skip_symlinks: |
Member
Author
There was a problem hiding this comment.
@pombredanne The docstring says Issue a warning if skip_symlinks is True and links target are missing., but I'm not sure why we would need to issue a warning if we want to skip extracting symlinks entirely? Right now, I'm skipping links but not issuing warnings.
Member
|
I am closing this in favor of #45 |
pombredanne
added a commit
that referenced
this pull request
Jul 30, 2022
* Introduce a new ExtractEvent that extract_tar() returns and contains error and warning messages. * Extract symlinks correctly. * do not try to strip leading slash in paths * do not try to treat broken links specially when extracting links Replacing: #42 Referenced-by: #44 Reported-by: Jono Yang <jyang@nexb.com> Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jono Yang jyang@nexb.com