Skip to content

Commit bd9fade

Browse files
committed
Update filter code
* We do not want to process download urls as a query Signed-off-by: Jono Yang <jyang@nexb.com>
1 parent 116751a commit bd9fade

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

packagedb/filters.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,10 @@ def filter(self, qs, value):
8181
if value.startswith("pkg:"):
8282
return qs.for_package_url(value)
8383

84-
if ":" in value:
84+
if "://" not in value and ":" in value:
8585
return super().filter(qs, value)
8686

87-
search_fields = ["type", "namespace", "name", "version"]
87+
search_fields = ["type", "namespace", "name", "version", "download_url"]
8888
lookups = Q()
8989
for field_names in search_fields:
9090
lookups |= Q(**{f"{field_names}__{self.lookup_expr}": value})

packagedb/tests/test_api.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -392,6 +392,8 @@ def test_package_api_list_endpoint_search(self):
392392
assert response.data.get('count') == 1
393393
response = self.client.get('/api/packages/?search={}'.format('12.35'))
394394
assert response.data.get('count') == 1
395+
response = self.client.get('/api/packages/?search={}'.format('https://dummy.com/dummy'))
396+
assert response.data.get('count') == 1
395397

396398
def test_package_api_retrieve_endpoint(self):
397399
response = self.client.get('/api/packages/{}/'.format(self.package.uuid))

0 commit comments

Comments
 (0)