Add support for Conda on-demand data collection #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Signed-off-by: ziad hany <ziadhany2016@gmail.com>
TG1999
reviewed
Sep 18, 2025
minecode/collectors/conda.py
Outdated
| subdir = qualifiers.get("subdir") or "noarch" | ||
| req_type = qualifiers.get("type") | ||
|
|
||
| def _conda_base_for_channel(channel: str) -> str: |
Contributor
There was a problem hiding this comment.
Why this is inside the function?
Collaborator
Author
There was a problem hiding this comment.
@TG1999 I just wanted to keep it simple and I copied this implementation from https://github.com/package-url/packageurl-python/blob/main/src/packageurl/contrib/purl2url.py#L560
Contributor
There was a problem hiding this comment.
@ziadhany why copy this? You can import the build download URL function for getting download URL, check luarocks collector
Collaborator
Author
There was a problem hiding this comment.
Ok, you are right, I will update it.
Fix test code formatting Signed-off-by: ziad hany <ziadhany2016@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.