Ensure that the cached file is not empty before using it #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelBochtler
force-pushed
the
zero-byte-whl
branch
3 times, most recently
from
6d09dee to
bcf912d
Compare
Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
We've observed multiple cases where a zero-byte file is cached, leading
to crashes with the error message:
zipfile.BadZipFile: File is not a zip file
I was not able to reproduce this issue reliably enough to identify the
root cause. However, adding a check to ensure that the cached file is
not empty before using it will mitigate the problem.
Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
MarcelBochtler
force-pushed
the
zero-byte-whl
branch
from
bcf912d to
46d9f8c
Compare
AyanSinhaMahapatra
approved these changes
Oct 31, 2025
Member
AyanSinhaMahapatra
left a comment
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
@MarcelBochtler LGTM!
The code change should fix the issue if it exists, but a small test is always nice to have in these cases.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've observed multiple cases where a zero-byte file is cached, leading to crashes crashes with the error message:
I was not able to reproduce this issue reliably enough to identify the root cause. However, adding a check to ensure that the cached file is not empty before using it will mitigate the problem.