implements an IDNA-encoded version of publicsuffix2. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
includes additional functionality for strict checks, ignoring wildcards, and finding eTLD only. maps main function of get_public_suffix() to get_sld() for clarity.
make test compatible with python2
…for merge into publicsuffix2 library.
|
upgrades pushed to new pypi module, publicsuffix3 |
|
@KnitCode I am sorry I had missed that PR entirely!!! |
|
@pombredanne ok.. i should have tried to ping you once more before pushing to pypi. someone asked for the ability to see the tld list, so i added that as an attribute this morning. that's only a few lines of code, so I can add that in and push it here. i can then delete publicsuffix3 on pypi... i'm assuming that won't be hard. ;) |
access the 'list' of TLDs. fixes some documentation typos. version bump to 20190808.
pombredanne
requested changes
Aug 9, 2019
pombredanne
approved these changes
Aug 11, 2019
|
Thank you ++! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure whether you'd want to include these change in main repo, but they include corrections and enhancements we use in our work. Addresses the change to the publicsuffix list to be utf-8 not idna-encoded, and contains some variations that we have found to be useful. updated the documentation in the code and README. but right now, it's a bit of a merge.
includes additional functionality for strict checks, ignoring
wildcards, and finding eTLD only. maps main function of
get_public_suffix() to get_sld() for clarity.