Skip to content

Conversation

@aayushkdev
Copy link
Collaborator

Reference #1840

  • Added a path display at the top of resource_table_view, which also serves as breadcrumbs for navigating to parent directories.
  • Added a Copy to Clipboard button that copies the current path.
image

Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
@tdruez
Copy link
Contributor

tdruez commented Sep 5, 2025

@aayushkdev The copy works fine but the "Path copied" label does not display properly, it's hidden behind the top element:
Screenshot 2025-09-05 at 18 09 53

Also, there's too much white space around the "/" separator.

Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
Signed-off-by: Aayush Kumar <aayush214.kumar@gmail.com>
@aayushkdev
Copy link
Collaborator Author

aayushkdev commented Sep 5, 2025

@aayushkdev The copy works fine but the "Path copied" label does not display properly, it's hidden behind the top element: Screenshot 2025-09-05 at 18 09 53

Also, there's too much white space around the "/" separator.

image

I have fixed it

@tdruez
Copy link
Contributor

tdruez commented Sep 8, 2025

@aayushkdev Works great! The next improvement should be to store the current state (current path) in the browser URL.
Also, we need to be able to load the state from thw URL, see

path(
"project/<slug:slug>/resources/<path:path>/",
views.CodebaseResourceDetailsView.as_view(),
name="resource_detail",
),
for providing the URL path to the view.

@tdruez tdruez merged commit 2af8198 into aboutcode-org:main Sep 8, 2025
11 checks passed
@aayushkdev
Copy link
Collaborator Author

@aayushkdev Works great! The next improvement should be to store the current state (current path) in the browser URL. Also, we need to be able to load the state from thw URL, see

path(
"project/<slug:slug>/resources/<path:path>/",
views.CodebaseResourceDetailsView.as_view(),
name="resource_detail",
),

for providing the URL path to the view.

Hey @tdruez I worked on this improvement over the weekend but my implementation was a bit different I used the url params which were already being passed to the template to load the state. Would be great if you could have a look at that pr #1853

@aayushkdev aayushkdev deleted the display-current-path branch September 8, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants