feat: add an option to disable throwing an error when !request.ok #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hello @RoCat ! Thanks for this feature request, can you switch target branch from |
Contributor
Author
|
Hi, change done ;) |
Member
|
Thank you! |
grandsilence
pushed a commit
to grandsilence/swagger-typescript-api-nextgen
that referenced
this pull request
May 16, 2022
…ot true (acacode#297) Co-authored-by: rcatoio <rcatoio@doubletrade.com> Co-authored-by: Sergey S. Volkov <js2me@outlook.com>
js2me
added a commit
that referenced
this pull request
Aug 15, 2022
* Feature: allow passing "patch" option to "swagger2openapi" (#283) Co-authored-by: cassel <xavier.cassel35@gmail.com> * Loads prettier config from user's project (#286) * fix: problem with missing HttpResponse type with --to-js option * fix: missing extractRequestBody field in type * fix(reject): fix reject and exit with code 1 if error (#295) * fix(reject): fix reject and exit with code 1 if error * feat: add a parameter to sort types and types properties (#299) Co-authored-by: rcatoio <rcatoio@doubletrade.com> * feat: add an option to disable throwing an error when request.ok is not true (#297) Co-authored-by: rcatoio <rcatoio@doubletrade.com> Co-authored-by: Sergey S. Volkov <js2me@outlook.com> * fix: fix missing `title` of object type (#303) * chore: refresh auto generated code; chore: add axios to dev deps * bump: up to 9.3.0 * bump: up to 9.3.1; fix: axios * chore: fix typo (#376) * 304 Support readOnly properties (#365) * allow mutually exclusive input options (#327) Co-authored-by: Sergey S. Volkov <js2me@outlook.com> * Update fetch-http-client.eta (#329) * BREAKING_CHANGE: add --extract-response-body option; bump: version to 9.4.0 * feat: added authorization token to headers Co-authored-by: MarcinFilipek <filipekmarcin180@gmail.com> * feat: --extract-response-error option * chore: refresh code gen tests * fix: change COMPLEX_NOT_OF to COMPLEX_NOT (#356) * Fix request format and allow for files in request - With code review changes (#350) * fix pick format allow for file array in form data requests * fixed code review suggestions Co-authored-by: Daniele De Matteo <daniele@kuama.net> Co-authored-by: Sergey S. Volkov <js2me@outlook.com> * Pass through required properties to allOf/anyOf/oneOf children (#342) * Pass through required properties to allOf children * extend fix to anyOf and oneOf * fix: account for children making parent fields required Co-authored-by: Anders Cassidy <anders.cassidy@dailypay.com> Co-authored-by: Daniel Playfair Cal <dcal@atlassian.com> Co-authored-by: Sergey S. Volkov <js2me@outlook.com> * Add option to change main Api class name (#320) * Update api.eta * Update index.d.ts * Update index.js * Update index.js * Update config.js Co-authored-by: Sergey S. Volkov <js2me@outlook.com> * fix: missing stringifyFormItem method; bump: up version to 10.0.0 * docs: update docs, changelog, fix: problem with complex types (makeAddRequiredToChildSchema) Co-authored-by: Xavier Cassel <57092100+xcassel@users.noreply.github.com> Co-authored-by: cassel <xavier.cassel35@gmail.com> Co-authored-by: Adrian Wieprzkowicz <Argeento@users.noreply.github.com> Co-authored-by: EvgenBabenko <evgen.babenko@gmail.com> Co-authored-by: RoCat <catoio.romain@gmail.com> Co-authored-by: rcatoio <rcatoio@doubletrade.com> Co-authored-by: 卡色 <cipchk@qq.com> Co-authored-by: 江麻妞 <50100681+jiangmaniu@users.noreply.github.com> Co-authored-by: Kasper Moskwiak <kasper.moskwiak@gmail.com> Co-authored-by: Ben Watkins <ben@outdatedversion.com> Co-authored-by: bonukai <bonukai@protonmail.com> Co-authored-by: baggoedw <92381702+baggoedw@users.noreply.github.com> Co-authored-by: Marcus Dunn <51931484+MarcusDunn@users.noreply.github.com> Co-authored-by: Daniele De Matteo <daniele@kuama.net> Co-authored-by: Daniel Playfair Cal <daniel.playfair.cal@gmail.com> Co-authored-by: Anders Cassidy <anders.cassidy@dailypay.com> Co-authored-by: Daniel Playfair Cal <dcal@atlassian.com>
|
Would love to see this option added to generateApi as well 🥳 EDIT: Actually, it seems to be working already, it's just missing from the typescript declaration (index.d.ts). |
|
It still isn't in the type definitions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my app i have a lot of "normal" HTTP errors (e.g. 404 when no "object" found etc...).
It's a pain to alway surround API call with try / catch (or then / catch) to avoid code crash when a simple if(response.ok) will be enough.
I added "disableThrowOnError" option to remove the throw error behavior on fetch-http-client.
Default value is false, then the current behavior remain unchanged.