feat(header): added application version label next to the title #7
Conversation
Add version label next to title Closes issue acadevmy#2
| @@ -1,5 +1,5 @@ | |||
| <div class="d-md-flex justify-content-between align-items-center"> | |||
| <h1 class="h3"><img src="assets/redis-white.png" />{{title}}</h1> | |||
| <h1 class="h3"><img src="assets/redis-white.png" />{{title}} {{version}}</h1> | |||
There was a problem hiding this comment.
Can you include the version string interpolation inside a tag, please?
There was a problem hiding this comment.
Do you mean something like this?
<h1 class="h3"><img src="assets/redis-white.png" />{{title + ' ' + version}}</h1>
| @@ -1,4 +1,5 @@ | |||
| import { Component, ChangeDetectorRef, AfterViewInit } from '@angular/core'; | |||
| import { version } from '../../../../../package.json'; | |||
There was a problem hiding this comment.
I think it's better to move this import into the environment files and use it throughout the application.
Thank you so much!
| }) | ||
| export class HeaderComponent implements AfterViewInit { | ||
| title = 'Redis Patterns'; | ||
| version = version; |
There was a problem hiding this comment.
Import from the environment, please. :)
| @@ -1,5 +1,5 @@ | |||
| <div class="d-md-flex justify-content-between align-items-center"> | |||
| <h1 class="h3"><img src="assets/redis-white.png" />{{title}} {{version}}</h1> | |||
| <h1 class="h3"><img src="assets/redis-white.png" />{{title + ' ' + version}}</h1> | |||
There was a problem hiding this comment.
Hi @fathorMB , i suggest a solution as:
<h1 class="h3"><img src="assets/redis-white.png" />{{title}} <span class="h6">{{version}}</span></h1>
What do you think about it?
| @@ -1,5 +1,5 @@ | |||
| import { Component, ChangeDetectorRef, AfterViewInit } from '@angular/core'; | |||
| import { version } from '../../../../../package.json'; | |||
| import { environment } from '../../../../environments/environment'; | |||
There was a problem hiding this comment.
How would you use that given that we are at the same directory level for environments and app? Sorry but never used it and i was wondering how this can be achieved in this scenario :)
There was a problem hiding this comment.
You can use: @app/../environments/environment'; ;)
src/environments/environment.ts
Outdated
| }, | ||
| cacheableHeaderKey: 'cacheable-request' | ||
| cacheableHeaderKey: 'cacheable-request', | ||
| version: version |
There was a problem hiding this comment.
You may use the property value shorthand and write only version. ;)
src/environments/environment.prod.ts
Outdated
| }, | ||
| cacheableHeaderKey: 'cacheable-request' | ||
| cacheableHeaderKey: 'cacheable-request', | ||
| version: version |
There was a problem hiding this comment.
You may use the property value shorthand and write only version. ;)
2 participants
Add version label next to title
Closes issue #2
I used the "version" property in package.json, able to reach it by setting the "resolveJsonModule" property to true in tsconfig.json.