dwt2d: fix memory leak in filename malloc #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParticleFilter in Rodinia fails when run on the head of GPGPU-Sim with a memory corruption. Looking further into the failures with valgrind, there were numerous uninitialized values in the arrays that were being accessed subsequently, causing the memory corruption error. To resolve this, all mallocs have been changed to callocs, which intiializes all locations to 0 and removes the error. From looking at the code, it appears these locations were assumed to be 0 all along, so this fix does not affect any functionality.
Print warning occurred because %d was used instead of %ld, this commit fixes that.
Update all cudaThreadSynchronize calls to cudaDeviceSynchronize, which has replaced it in more modern CUDA versions.
fix particlefilter so it can run in GPGPU-Sim
The malloc for the imgsrc filename in dwt2d leaks memory because it does not allocate space for the trailing \0 to end the string. This commit fixes that.
|
I confirmed these with valgrind -- putting in the changes made the leaks go away. |
|
Thanks, Matt. Good old strlen :) |
|
Better? |
LAhmos
pushed a commit
to purdue-aalp/gpu-app-collection-public
that referenced
this pull request
Jul 6, 2025
dwt2d: fix memory leak in filename malloc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The malloc for the imgsrc filename in dwt2d leaks memory because it
does not allocate space for the trailing \0 to end the string. This
commit fixes that.