Merge 8fcf75b into 3bd64ce

Author: acid1103

src/sorted-array.ts

@@ -415,11 +415,23 @@ export class SortedArray<T> implements Array<T> {
     // INTERFACE METHODS
     public toString(): string {
         this._sort();
-        return this.unwrap().toString();
+        const unwrapped = this.unwrap();
+        for (let i = 0; i < unwrapped.length; i++) {
+            if (unwrapped[i] as any === this) {
+                unwrapped[i] = "[Circular]" as unknown as T;
+            }
+        }
+        return unwrapped.toString();
     }
     public toLocaleString(): string {
         this._sort();
-        return this.unwrap().toLocaleString();
+        const unwrapped = this.unwrap();
+        for (let i = 0; i < unwrapped.length; i++) {
+            if (unwrapped[i] as any === this) {
+                unwrapped[i] = "[Circular]" as unknown as T;
+            }
+        }
+        return unwrapped.toLocaleString();
     }
     public pop(): T {
         this._sort();

test/test.ts

@@ -395,12 +395,22 @@ describe("SortedArray", function() {
                 const sa = newsa();
                 deepStrictEqual(sa.toString(), expected.toString());
             });
+            it("should not error in a circular array", function() {
+                const sa = new SortedArray<SortedArray<any>>(() => 0);
+                sa.add(sa);
+                strictEqual(sa.toString(), "[Circular]");
+            });
         });
         describe("#toLocaleString", function() {
             it("should mirror the functionality of Array#toLocaleString", function() {
                 const sa = newsa();
                 deepStrictEqual(sa.toLocaleString(), expected.toLocaleString());
             });
+            it("should not error in a circular array", function() {
+                const sa = new SortedArray<SortedArray<any>>(() => 0);
+                sa.add(sa);
+                strictEqual(sa.toLocaleString(), "[Circular]");
+            });
         });
         describe("#pop", function() {
             it("should remove and return the last element", function() {