Skip to content

Commit fa75caa

Browse files
author
郑树新
committed
optimize and test
1 parent 17963dc commit fa75caa

File tree

7 files changed

+49
-30
lines changed

7 files changed

+49
-30
lines changed

examples/gin-server/gin-server.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package main
22

33
import (
44
"flag"
5+
"fmt"
56
"log"
67
"net"
78
"sync"
@@ -44,6 +45,8 @@ func parseArgs() {
4445
}
4546

4647
func main() {
48+
fmt.Println("Current master-go version:", master.Version)
49+
4750
// parse args from commandline or acl_master's exec
4851
parseArgs()
4952

examples/go-echod/main.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ var (
3535
)
3636

3737
func main() {
38+
fmt.Println("Current master-go version:", master.Version)
39+
3840
flag.StringVar(&listenAddrs, "listen", "127.0.0.1:28880, 127.0.0.1:28881",
3941
"listen addr in alone running")
4042

examples/go-httpd/main.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ var (
2525
)
2626

2727
func main() {
28+
fmt.Println("Current master-go version:", master.Version)
29+
2830
flag.Parse()
2931

3032
master.Prepare()

examples/httpd-handler/main.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ func (handler MyHandler) ServeHTTP(w http.ResponseWriter, req *http.Request) {
4343
}
4444

4545
func main() {
46+
fmt.Println("Current master-go version:", master.Version)
47+
4648
flag.StringVar(&filePath, "c", "dummy.cf", "configure filePath")
4749
flag.StringVar(&listenAddrs, "listen", "127.0.0.1:8088", "listen addr in alone running")
4850
flag.Parse()

service.go

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,12 @@ var (
7676
MasterUnprivileged bool
7777
// MasterChroot bool
7878
MasterSocketCount int = 1
79+
7980
Alone bool
8081
)
8182

83+
const Version string = "1.0.3"
84+
8285
// setOpenMax set the max opened file handles for current process which let
8386
// the process can handle more connections.
8487
func setOpenMax() {
@@ -262,7 +265,7 @@ func chroot() {
262265
func GetListenersByAddrs(addrs string) ([]net.Listener, error) {
263266
if len(addrs) == 0 {
264267
log.Println("No valid addrs for listening")
265-
return nil, errors.New("No valid addrs for listening")
268+
return nil, errors.New("no valid addrs for listening")
266269
}
267270

268271
// split addrs like "xxx.xxx.xxx.xxx:port; xxx.xxx.xxx.xxx:port"
@@ -283,7 +286,7 @@ func GetListenersByAddrs(addrs string) ([]net.Listener, error) {
283286
log.Println("Listen", addr, "error:", err)
284287
}
285288
if len(listeners) == 0 {
286-
return nil, errors.New("No listeners were created!")
289+
return nil, errors.New("no listeners were created!")
287290
}
288291
return listeners, nil
289292
}
@@ -293,7 +296,7 @@ func GetListenersByAddrs(addrs string) ([]net.Listener, error) {
293296
func GetListeners() ([]net.Listener, error) {
294297
listeners := []net.Listener(nil)
295298
for fd := listenFdStart; fd < listenFdStart+listenFdCount; fd++ {
296-
file := os.NewFile(uintptr(fd), "open one listenfd")
299+
file := os.NewFile(uintptr(fd), "open one listen fd")
297300
if file == nil {
298301
log.Printf("os.NewFile failed for fd=%d", fd)
299302
continue
@@ -315,7 +318,7 @@ func GetListeners() ([]net.Listener, error) {
315318

316319
if len(listeners) == 0 {
317320
log.Println("No listener created!")
318-
return nil, errors.New("No listener created")
321+
return nil, errors.New("no listener created")
319322
} else {
320323
log.Printf("Listeners's len=%d\r\n", len(listeners))
321324
}
@@ -359,7 +362,7 @@ func ServiceInit(addrs string, stopHandler func(bool)) ([]net.Listener, error) {
359362

360363
if len(listeners) == 0 {
361364
log.Println("No listener available!")
362-
return nil, errors.New("No listener available")
365+
return nil, errors.New("no listener available")
363366
}
364367

365368
// In daemon mode, the backend monitor fiber will be created for

service_windows.go

Lines changed: 31 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,13 @@ var (
4343
doneChan chan bool = make(chan bool)
4444
connCount int = 0
4545
connMutex sync.RWMutex
46-
stopping bool = false
47-
prepareCalled bool = false
46+
stopping = false
47+
prepareCalled = false
4848
)
4949

5050
// from configure file of the app
5151
var (
52+
AppConf *Config
5253
MasterService string
5354
MasterLogPath string
5455
MasterOwner string
@@ -60,6 +61,9 @@ var (
6061
AppWaitLimit int = 10
6162
AppAccessAllow string = "all"
6263
Appthreads int = 0
64+
65+
TlsCertFile string
66+
TlsKeyFile string
6367
)
6468

6569
// from command args
@@ -149,10 +153,10 @@ func Prepare() {
149153

150154
parseArgs()
151155

152-
conf := new(Config)
153-
conf.InitConfig(confPath)
156+
AppConf = new(Config)
157+
AppConf.InitConfig(confPath)
154158

155-
MasterLogPath = conf.GetString("master_log")
159+
MasterLogPath = AppConf.GetString("master_log")
156160
if len(MasterLogPath) > 0 {
157161
f, err := os.OpenFile(MasterLogPath, os.O_RDWR|os.O_CREATE|os.O_APPEND, 0644)
158162
if err != nil {
@@ -163,21 +167,24 @@ func Prepare() {
163167
}
164168
}
165169

166-
MasterService = conf.GetString("master_service")
167-
MasterOwner = conf.GetString("master_owner")
168-
MasterArgs = conf.GetString("master_args")
169-
170-
AppRootDir = conf.GetString("app_queue_dir")
171-
AppUseLimit = conf.GetInt("app_use_limit")
172-
AppIdleLimit = conf.GetInt("app_idle_limit")
173-
AppQuickAbort = conf.GetBool("app_quick_abort")
174-
AppWaitLimit = conf.GetInt("app_wait_limit")
175-
AppAccessAllow = conf.GetString("app_access_allow")
176-
Appthreads = conf.GetInt("app_threads")
170+
MasterService = AppConf.GetString("master_service")
171+
MasterOwner = AppConf.GetString("master_owner")
172+
MasterArgs = AppConf.GetString("master_args")
173+
174+
AppRootDir = AppConf.GetString("app_queue_dir")
175+
AppUseLimit = AppConf.GetInt("app_use_limit")
176+
AppIdleLimit = AppConf.GetInt("app_idle_limit")
177+
AppQuickAbort = AppConf.GetBool("app_quick_abort")
178+
AppWaitLimit = AppConf.GetInt("app_wait_limit")
179+
AppAccessAllow = AppConf.GetString("app_access_allow")
180+
Appthreads = AppConf.GetInt("app_threads")
177181
if Appthreads > 0 {
178182
runtime.GOMAXPROCS(Appthreads)
179183
}
180184

185+
TlsCertFile = AppConf.GetString("tls_cert_file")
186+
TlsKeyFile = AppConf.GetString("tls_key_file")
187+
181188
log.Printf("Args: %s, AppAccessAllow: %s\r\n", MasterArgs, AppAccessAllow)
182189
}
183190

@@ -196,8 +203,8 @@ func chroot() {
196203
// and call this function to listen the given addrs
197204
func GetListenersByAddrs(addrs string) ([]net.Listener, error) {
198205
if len(addrs) == 0 {
199-
log.Println("No valid addrs for listening")
200-
return nil, errors.New("No valid addrs for listening")
206+
log.Println("no valid addresses for listening")
207+
return nil, errors.New("no valid addresses for listening")
201208
}
202209

203210
// split addrs like "xxx.xxx.xxx.xxx:port; xxx.xxx.xxx.xxx:port"
@@ -218,8 +225,8 @@ func GetListenersByAddrs(addrs string) ([]net.Listener, error) {
218225
log.Println("Listen", addr, "error:", err)
219226
}
220227
if len(listeners) == 0 {
221-
log.Println("No listeners were createdd")
222-
return nil, errors.New("No listeners were created")
228+
log.Println("no listeners were created")
229+
return nil, errors.New("no listeners were created")
223230
}
224231
return listeners, nil
225232
}
@@ -229,7 +236,7 @@ func GetListenersByAddrs(addrs string) ([]net.Listener, error) {
229236
func GetListeners() ([]net.Listener, error) {
230237
listeners := []net.Listener(nil)
231238
for fd := listenFdStart; fd < listenFdStart+listenFdCount; fd++ {
232-
file := os.NewFile(uintptr(fd), "open one listenfd")
239+
file := os.NewFile(uintptr(fd), "open one listen fd")
233240
if file == nil {
234241
log.Printf("os.NewFile failed for fd=%d", fd)
235242
continue
@@ -251,7 +258,7 @@ func GetListeners() ([]net.Listener, error) {
251258

252259
if len(listeners) == 0 {
253260
log.Println("No listener created!")
254-
return nil, errors.New("No listener created")
261+
return nil, errors.New("no listener created")
255262
} else {
256263
log.Printf("Listeners's len=%d", len(listeners))
257264
}
@@ -271,7 +278,7 @@ func ServiceInit(addrs string, stopHandler func(bool)) ([]net.Listener, error) {
271278
initHandler()
272279
}
273280

274-
// if addrs not empty, alone mode will be used, or daemon mode be used
281+
// if addresses not empty, alone mode will be used, or daemon mode be used
275282

276283
var listeners []net.Listener
277284
var daemonMode bool
@@ -295,7 +302,7 @@ func ServiceInit(addrs string, stopHandler func(bool)) ([]net.Listener, error) {
295302

296303
if len(listeners) == 0 {
297304
log.Println("No listener available!")
298-
return nil, errors.New("No listener available")
305+
return nil, errors.New("no listener available")
299306
}
300307

301308
// In daemon mode, the backend monitor fiber will be created for

web_service.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func WebDaemonStart(handler http.Handler) error{
4848
return WebStart("", handler)
4949
}
5050

51-
// start WEB service with the specified listening addrs
51+
// WebStart start WEB service with the specified listening addrs
5252
func WebStart(addrs string, handler http.Handler) error {
5353
var listeners []net.Listener
5454
listeners, err := ServiceInit(addrs, webStop)

0 commit comments

Comments
 (0)