Re-add paid member check on membership checkout sessions

[devksingh4]

Summary by CodeRabbit

• Bug Fixes
  • Restored membership validation enforcement in the membership flow. The system now properly validates paid-member status during the membership process while maintaining existing checkout functionality.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Refactored membership route by removing Entra role-based client provisioning logic and associated imports. The code now uses pre-configured clients (secretsManagerClient, dynamoClient, redisClient) from fastify context. Simultaneously enabled a previously commented paid-member validation check that throws an error when isPaidMember is true.

Changes

Cohort / File(s)	Summary
Entra role provisioning removal src/api/routes/v2/membership.ts	Removed getAuthorizedClients function and Entra-related imports (Entra credentials, Secrets Manager, DynamoDB client creation via assumed roles). Code now directly references existing fastify clients instead of dynamically assuming roles.
Paid-member validation enablement src/api/routes/v2/membership.ts	Uncommented and activated paid-member check that throws ValidationError when isPaidMember is true. Checkout flow remains intact but now uses existing client instances.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify the rationale for removing Entra role-based provisioning and confirm existing fastify clients are properly pre-configured with necessary credentials
• Confirm that the activated paid-member validation logic is correct and represents the intended business rule (error on isPaidMember === true)
• Ensure no edge cases exist from eliminating dynamic role assumption in the checkout flow

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dsingh14/fix-checkout

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between a30528e and 5398cc9.

📒 Files selected for processing (1)

• src/api/routes/v2/membership.ts (2 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

💰 Infracost report

Monthly estimate generated

_{This comment will be updated when code changes.}