Companies Page #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jvil26
commented
Sep 14, 2022
Jvil26
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…into companies-page
Jvil26
force-pushed
the
companies-page
branch
from
312338b to
6a0157b
Compare
farisashai
force-pushed
the
companies-page
branch
from
6a0157b to
76cab9a
Compare
…into companies-page
farisashai
requested changes
Nov 9, 2022
Member
farisashai
left a comment
farisashai
left a comment
There was a problem hiding this comment.
Overall layout looks good!
Let's make sure the code is fully ready for the live production website in this PR before we merge it. Try to be considerate about what things would look off if you were an actual user viewing the page to gain more information about our career fair.
I left some comments about rem usage and color variables, etc. In general, I'm only going to comment once per review on a distinct issue but make sure you handle it everywhere that it applies.
farisashai
requested changes
Nov 11, 2022
Member
farisashai
left a comment
farisashai
left a comment
There was a problem hiding this comment.
Everything looks much better! Just a couple small comments to address - let me know as soon as these are fixed so we can merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.