Skip to content
This repository was archived by the owner on Mar 16, 2024. It is now read-only.

Conversation

@thedadams
Copy link
Contributor

@thedadams thedadams commented Jul 28, 2023

It was decided that if a user doesn't specify any region information for a project, then the project supports all region by default. Additionally, it is now possible that a user can specify that a project supports all regions by using the '*' value.

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Copy link
Contributor

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no blocking comments :)

It was decided that if a user doesn't specify any region information for
a project, then the project supports all region by default.
Additionally, it is now possible that a user can specify that a project
supports all regions by using the '*' value.

Signed-off-by: Donnie Adams <donnie@acorn.io>
@thedadams thedadams merged commit 56da045 into acorn-io:main Jul 31, 2023
@thedadams thedadams deleted the gh-m797 branch July 31, 2023 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants