This repository was archived by the owner on Mar 16, 2024. It is now read-only.
Reuse Let's Encrypt fields on install #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After initial install we don't want to prompt the user to agree to Let's Encrypt TOS if they already did. So, we check if we already have that bit of configuration server side before prompting them. Also, clean up the code a bit. Signed-off-by: Craig Jellick <craig@acorn.io>
Closed
tylerslaton
approved these changes
Nov 28, 2022
Comment on lines
+155
to
+158
| email := opts.Config.LetsEncryptEmail | ||
| if email == "" { | ||
| email = serverConf.LetsEncryptEmail | ||
| } |
Contributor
|
Looks good to me minus CI failing. |
Member
Author
|
Ran the test locally and reran here. Passed in both. going to chalk it up to a fluke for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After initial install we don't want to prompt the user to agree to Let's
Encrypt TOS if they already did. So, we check if we already have that
bit of configuration server side before prompting them.
Also, clean up the code a bit.
Signed-off-by: Craig Jellick craig@acorn.io
obot-platform/obot#790