Skip to content

fix[N03] Fixed inconsistant token metadata versioning #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2022
Merged

fix[N03] Fixed inconsistant token metadata versioning #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
892f6bd
fix[N03] Fixed inconsistant token metadata versioning
chrismaree Mar 16, 2022
91a08a9
nit
chrismaree Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/LpTokenFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ contract LpTokenFactory is LpTokenFactoryInterface {
*/
function createLpToken(address l1Token) public returns (address) {
ExpandedERC20 lpToken = new ExpandedERC20(
_append("Across ", IERC20Metadata(l1Token).name(), " LP Token"), // LP Token Name
_append("Across V2 ", IERC20Metadata(l1Token).name(), " LP Token"), // LP Token Name
_append("Av2-", IERC20Metadata(l1Token).symbol(), "-LP"), // LP Token Symbol
IERC20Metadata(l1Token).decimals() // LP Token Decimals
);
Expand Down
2 changes: 1 addition & 1 deletion test/HubPool.Admin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe("HubPool Admin functions", function () {

const lpToken = await (await getContractFactory("ExpandedERC20", owner)).attach(pooledTokenStruct.lpToken);
expect(await lpToken.callStatic.symbol()).to.equal("Av2-WETH-LP");
expect(await lpToken.callStatic.name()).to.equal("Across Wrapped Ether LP Token");
expect(await lpToken.callStatic.name()).to.equal("Across V2 Wrapped Ether LP Token");
});
it("Only owner can enable L1 Tokens for liquidity provision", async function () {
await expect(hubPool.connect(other).enableL1TokenForLiquidityProvision(weth.address)).to.be.reverted;
Expand Down