feat: deploy scroll, blast, mode, redstone, zora, ink, and soneium spoke pools #1081

bmzig · 2025-08-25T19:40:13Z

No description provided.

nicholaspai · 2025-08-26T16:46:35Z

script/utils/ExtractDeployedFoundryAddresses.ts

    }

-    content.push("");
+    // content.push("");


Left over comment

grasphoper · 2025-08-26T16:54:04Z

Do we want to put these new addresses into deployments.json for backward compatibility for now? AFAIK, bits of relayer code rely on deployments.json being a source of truth.

Otherwise when bumping the contracts version in the relayer, we need to handle these changes in ContractUtils.ts

The base branch was changed.

fusmanii · 2025-08-26T17:18:43Z

@grasphoper I was hoping to make the new broadcast/deployed-addresses.json as source of truth since it has all the addresses from deployments.json and all new deploys from broadcast

also its automatically kept up to date by with extract-addresses script

pxrl · 2025-08-29T14:22:33Z

Do we want to put these new addresses into deployments.json for backward compatibility for now? AFAIK, bits of relayer code rely on deployments.json being a source of truth.

Otherwise when bumping the contracts version in the relayer, we need to handle these changes in ContractUtils.ts

These are only implementation contracts so we don't actually want them in deployments.json - if we updated them there then it'd break the bots.

pxrl · 2025-09-09T21:11:36Z

broadcast/deployed-addresses.json

+        },
+        "Lens_SpokePool": {
+          "address": "0xc7772ce23a3ed7f87fe51b87617c7c7d21f15d39",
+          "transaction_hash": "0xa4938f34425c997b4686b5bad4f66b04bfbc2270dfe9c00b8f134da6a7b6edf5",
+          "block_number": 4092265
        }


Do we want to include this deployment?

done 9fe5920

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

This reverts commit 8ccecb1. Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Signed-off-by: bennett <bennett@umaproject.org>

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

…/deployV4Extra

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

…/deployV4Extra

grasphoper · 2025-09-29T22:24:06Z

foundry.lock

+  "lib/forge-std": {
+    "rev": "6bce1540c7a5d1c40eec032a1ae16f0e01f82b92"
+  }
+}


@fusmanii could you explain why we need this?

this is just pinning lib/forge-std version, not sure why it hasn't been added to the repo already

grasphoper · 2025-09-29T22:27:52Z

scripts/veryfyBytecode.sh

+    echo "✅ Code match"
+else
+    echo "❌ Code mismatch"
 fi


@fusmanii For the future, we should probably standardize the way we do this "veryfying of bytecode" action.

We've got this script, and 2 more: tasks/verifyBytecode.ts , tasks/verifySpokePool.ts

The latter script seems unused currently (am I wrong here @pxrl?) I like the idea of it: sanity checking some params for the spoke. It'd be nice to keep that up-to-date and potentially also create a foundry version.

It'd be nice if we consolidated all this functionality into some single foundry script that could work for any deployment: either foundry or hardhat.

These are a little vague thoughts and only tangentially relevant

I added this as a quick way to check bytecode of a deployed contract using foundry but I agree, ideally there would be one script that can verify bytecode/params of a spoke pool regardless if it was deployed using foundry or hardhat

The latter script seems unused currently (am I wrong here @pxrl?) I like the idea of it: sanity checking some params for the spoke. It'd be nice to keep that up-to-date and potentially also create a foundry version.

Yeah; it's only sporadically used, but it's a fairly inexpensive way of checking for any configuration issues in the SpokePool. There's value in checking that the onchain values match what was (intended to be) configured by the deployment script, but there's secondary value in dumping the values so that people can sanity check the results for anything that might be misconfigured in the deployment script. The visual inspection might catch issues that we are prone to overlook if the error is buried in a config file.

Ideally it could use executed post-deployment and the output could form part of the eventual PR to add the SpokePool artefacts.

bmzig requested review from mrice32, nicholaspai and pxrl as code owners August 25, 2025 19:40

fusmanii force-pushed the faisal/foundry-migration-deploy-scripts branch from 3c02f42 to 56637f5 Compare August 25, 2025 22:09

fusmanii force-pushed the bz/deployV4Extra branch 2 times, most recently from d19e0d1 to af5979f Compare August 26, 2025 14:08

Base automatically changed from faisal/foundry-migration-deploy-scripts to faisal/foundry-migration-deployment-utils August 26, 2025 14:51

Base automatically changed from faisal/foundry-migration-deployment-utils to faisal/foundry-migration-constants August 26, 2025 14:58

fusmanii force-pushed the bz/deployV4Extra branch 2 times, most recently from 9ff6088 to 676fbb3 Compare August 26, 2025 15:24

fusmanii changed the title ~~feat: deploy scroll, blast, zora, and ink~~ feat: deploy scroll, blast, mode, redstone, zora, ink, lens, and soneium spoke pools Aug 26, 2025

nicholaspai previously approved these changes Aug 26, 2025

View reviewed changes

nicholaspai reviewed Aug 26, 2025

View reviewed changes

Base automatically changed from faisal/foundry-migration-constants to master August 26, 2025 16:58

fusmanii force-pushed the bz/deployV4Extra branch from 676fbb3 to 4ed7873 Compare August 26, 2025 17:02

fusmanii requested a review from nicholaspai August 26, 2025 17:42

fusmanii force-pushed the bz/deployV4Extra branch 2 times, most recently from 681c342 to a460888 Compare August 27, 2025 18:59

fusmanii force-pushed the bz/deployV4Extra branch 2 times, most recently from 35007a7 to 4e83ba9 Compare August 29, 2025 21:14

fusmanii previously approved these changes Sep 9, 2025

View reviewed changes

pxrl reviewed Sep 9, 2025

View reviewed changes

fusmanii added 4 commits September 9, 2025 17:13

Added address extraction script

011cf43

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Renamed readme

39b6395

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

feat(Foundry): Added hubpool, ethereum and arbitrum spoke pool scripts

226abc5

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Renamed arb deploy script

a81cb69

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

fusmanii and others added 10 commits September 9, 2025 17:13

Added deploy scripts for v4 upgrades

bcc65f5

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Deployed mode, redstone, lens and soneium spoke pools

903d736

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Revert "Deployed mode, redstone, lens and soneium spoke pools"

34f87a0

This reverts commit 8ccecb1. Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

deploy scroll, blast, zora, and ink

21c1234

Signed-off-by: bennett <bennett@umaproject.org>

update

b784a44

Signed-off-by: bennett <bennett@umaproject.org>

Deployed mode, redstone, lens and soneium spoke pools

1df6d63

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Fixed addresses extraction contract labelling

fae7423

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Removed commended out line

738951c

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Format the script

54538c4

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Add the extra # back

42a4066

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

fusmanii force-pushed the bz/deployV4Extra branch from 4e83ba9 to 42a4066 Compare September 9, 2025 21:13

fusmanii dismissed their stale review via 94cfe45 September 9, 2025 21:18

Updated deployed address json/md

9fe5920

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

fusmanii force-pushed the bz/deployV4Extra branch from 94cfe45 to 9fe5920 Compare September 9, 2025 21:19

fusmanii added 3 commits September 17, 2025 10:03

Merge branch 'master' of github.com:across-protocol/contracts into bz…

dea5b89

…/deployV4Extra

Removed merge issue

2ff9c0b

Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>

Merge branch 'master' of github.com:across-protocol/contracts into bz…

073ef8d

…/deployV4Extra

fusmanii changed the title ~~feat: deploy scroll, blast, mode, redstone, zora, ink, lens, and soneium spoke pools~~ feat: deploy scroll, blast, mode, redstone, zora, ink, and soneium spoke pools Sep 29, 2025

fusmanii requested review from grasphoper and pxrl September 29, 2025 14:50

grasphoper reviewed Sep 29, 2025

View reviewed changes

fusmanii requested a review from grasphoper October 1, 2025 00:10

pxrl approved these changes Oct 1, 2025

View reviewed changes

fusmanii merged commit d8cb921 into master Oct 2, 2025
10 checks passed

fusmanii deleted the bz/deployV4Extra branch October 2, 2025 13:11

Uh oh!

feat: deploy scroll, blast, mode, redstone, zora, ink, and soneium spoke pools #1081

feat: deploy scroll, blast, mode, redstone, zora, ink, and soneium spoke pools #1081

Uh oh!

Conversation

bmzig commented Aug 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

grasphoper commented Aug 26, 2025

Uh oh!

fusmanii commented Aug 26, 2025

Uh oh!

pxrl commented Aug 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pxrl Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pxrl Oct 1, 2025 •

edited

Loading