Skip to content

fix[N11] Fix Residual privleged roles #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 18, 2022
Merged

fix[N11] Fix Residual privleged roles #109

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7bc27e1
fix[N04] Remove LPTokenFactory Magic numbers
chrismaree Mar 16, 2022
ec72f3b
fix[N04] Remove LPTokenFactory Magic numbers
chrismaree Mar 16, 2022
4597b8f
fix[N11] Fix Residual privleged roles
chrismaree Mar 16, 2022
cbe4b4c
Update contracts/LpTokenFactory.sol
chrismaree Mar 18, 2022
78d49b0
nit
chrismaree Mar 18, 2022
21cdccd
nit
chrismaree Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions contracts/LpTokenFactory.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ contract LpTokenFactory is LpTokenFactoryInterface {
_append("Av2-", IERC20Metadata(l1Token).symbol(), "-LP"), // LP Token Symbol
IERC20Metadata(l1Token).decimals() // LP Token Decimals
);
lpToken.addMember(1, msg.sender); // Set this contract as the LP Token's minter.
lpToken.addMember(2, msg.sender); // Set this contract as the LP Token's burner.
lpToken.addMinter(msg.sender); // Set the caller as the LP Token's minter.
lpToken.addBurner(msg.sender); // Set the caller as the LP Token's burner.
lpToken.resetOwner(msg.sender); // Set the caller as the LP Token's owner.

return address(lpToken);
}
Expand Down