feat: Hypercorelib - clean up decimal conversion functions #1139
Conversation
| ); | ||
|
|
||
| if (amounts.evm != 0) { | ||
| (uint256 _amountEVMToSend, uint64 _amountCoreToReceive) = maximumEVMSendAmountToAmounts(amountEVM, decimalDiff); |
There was a problem hiding this comment.
do we even want to modify the EVM send amount here? or rely on the higher level contract to do this?
| // Transfer the tokens to this contract's address on HyperCore | ||
| IERC20(erc20EVMAddress).safeTransfer(toAssetBridgeAddress(erc20CoreIndex), amounts.evm); | ||
| ) internal returns (uint256 amountEVMSent, uint64 amountCoreToReceive) { | ||
| (uint256 _amountEVMToSend, uint64 _amountCoreToReceive) = maximumEVMSendAmountToAmounts(amountEVM, decimalDiff); |
There was a problem hiding this comment.
do we even want to modify the EVM send amount here? or rely on the higher level contract to do this?
There was a problem hiding this comment.
I honestly would expect the higher level caller to always use the maximumEVMSendAmountToAmounts themselves when sending.
If they don't, they're risking making an error in accounting. And then the maximumEVMSendAmountToAmounts won't save them anyway?
Actually, if we do leave these in, we can assert the returned values against the actual amounts that we're sending. This costs a bit of gas and is kind of a "hidden execution flow", but I'm leaning we leave these here I guess.
tbwebb22
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
|
This PR is great, adds just what we need! |
Cleans up functionality around decimal conversion and EVM <> Core bridging dust calculations
Adds spotPx function for getting spot market price